RFR: 6757: Selector for attribute in the flame graph

[Marcus Hirt]

On Wed, 19 Jan 2022 13:04:35 GMT, Jean-Philippe Bempel <jpbempel at openjdk.org> wrote:

> Add support for aggregating flamegraph by custom attribute.
> 
> Available attributes are chosen by their content type (number or memory).
> 
> <img width="1435" alt="Screenshot 2022-04-22 at 08 35 
> 47" src="https://user-images.githubusercontent.com/4610701/164617514-34d56474-768a-4f96-8d92-5ba617aca45a.png">
> 
> <img width="1437" alt="Screenshot 2022-04-22 at 08 36 06" src="https://user-images.githubusercontent.com/4610701/164617547-c0da25a8-d5f2-4739-bbd9-d41a3dd98d02.png">
> 
> Added support on StacktraceView:
> 
> <img width="1098" alt="Screenshot 2022-05-10 at 22 20 13" src="https://user-images.githubusercontent.com/4610701/167715364-04ca6580-4389-4c21-b6da-5d7d0fcae63b.png">

Great work!

A few general comments:
* When selecting an attribute only present in certain event types, perhaps it would make sense to first filter on those types? Now the source event count will remain the same, even when only a few events actually has the attribute in question.
* Perhaps "Samples" should always be on the top of the menu, with a delimiter after, and with a small description. E.g. Samples (Event Count).

-------------

PR: https://git.openjdk.org/jmc/pull/365