RFR: 6757: Selector for attribute in the flame graph

[Marcus Hirt]

On Wed, 19 Jan 2022 13:04:35 GMT, Jean-Philippe Bempel <jpbempel at openjdk.org> wrote:

> Add support for aggregating flamegraph by custom attribute.
> 
> Available attributes are chosen by their content type (number or memory).
> 
> <img width="1435" alt="Screenshot 2022-04-22 at 08 35 
> 47" src="https://user-images.githubusercontent.com/4610701/164617514-34d56474-768a-4f96-8d92-5ba617aca45a.png">
> 
> <img width="1437" alt="Screenshot 2022-04-22 at 08 36 06" src="https://user-images.githubusercontent.com/4610701/164617547-c0da25a8-d5f2-4739-bbd9-d41a3dd98d02.png">
> 
> Added support on StacktraceView:
> 
> <img width="1098" alt="Screenshot 2022-05-10 at 22 20 13" src="https://user-images.githubusercontent.com/4610701/167715364-04ca6580-4389-4c21-b6da-5d7d0fcae63b.png">

Changes requested by hirt (Lead).

application/org.openjdk.jmc.flightrecorder.flameview/src/main/java/org/openjdk/jmc/flightrecorder/flameview/views/FlameGraphView.java line 50:

> 48: import static org.openjdk.jmc.flightrecorder.flameview.MessagesUtils.getFlameviewMessage;
> 49: 
> 50: import java.io.BufferedWriter;

Need to update the copyright year.

application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/common/AttributeSelection.java line 1:

> 1: package org.openjdk.jmc.flightrecorder.ui.common;

Need a copyright header.

application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/views/stacktrace/StacktraceView.java line 99:

> 97: import org.openjdk.jmc.common.IState;
> 98: import org.openjdk.jmc.common.collection.SimpleArray;
> 99: import org.openjdk.jmc.common.item.IAttribute;

Need to update the copyright year.

application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/views/stacktrace/StacktraceView.java line 800:

> 798: 		String attrName = currentAttribute != null ? currentAttribute.getName() : null;
> 799: 		createAttributeSelection(attrName, attrList);
> 800: 

Unnecessary new line.

core/org.openjdk.jmc.flightrecorder.serializers/src/main/java/org/openjdk/jmc/flightrecorder/serializers/json/FlameGraphJsonSerializer.java line 59:

> 57: 
> 58: import org.openjdk.jmc.common.IMCFrame;
> 59: import org.openjdk.jmc.common.item.Aggregators;

Need to update the copyright year.

core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/stacktrace/StacktraceFrame.java line 37:

> 35: import org.openjdk.jmc.common.IMCFrame;
> 36: import org.openjdk.jmc.common.collection.SimpleArray;
> 37: import org.openjdk.jmc.common.item.Aggregators;

Need to update the copyright year.

core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/stacktrace/StacktraceModel.java line 47:

> 45: import org.openjdk.jmc.common.collection.ArrayToolkit;
> 46: import org.openjdk.jmc.common.collection.SimpleArray;
> 47: import org.openjdk.jmc.common.item.IAttribute;

Need to update the copyright year.

core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/stacktrace/tree/StacktraceTreeModel.java line 48:

> 46: import org.openjdk.jmc.common.item.IMemberAccessor;
> 47: import org.openjdk.jmc.common.unit.IQuantity;
> 48: import org.openjdk.jmc.common.unit.UnitLookup;

Need to update the copyright year.

core/tests/org.openjdk.jmc.flightrecorder.test/src/main/java/org/openjdk/jmc/flightrecorder/test/StacktraceTreeModelTest.java line 85:

> 83: 		assertEquals(leafValues.size(), 3);
> 84: 		Map<String, List<Double>> expected = new HashMap<>();
> 85: 		expected.put("Arrays.copyOfRange(char[], int, int)", asList(104.0 / 1024));

Need to update the copyright year.

-------------

PR: https://git.openjdk.org/jmc/pull/365