RFR: 7831: Add new view for hierarchical edge bundling [v14]
Alex Ciminian
duke at openjdk.org
Fri Aug 5 19:14:15 UTC 2022
On Thu, 4 Aug 2022 12:57:36 GMT, Marcus Hirt <hirt at openjdk.org> wrote:
>> Brice Dutheil has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Add newlines to end of all files
>
> application/org.openjdk.jmc.feature.flightrecorder/feature.xml line 203:
>
>> 201:
>> 202: <plugin
>> 203: id="org.openjdk.jmc.flightrecorder.hierarchical-edge"
>
> Nit: I'd prefer to skip the dash.
Renamed to `dependencyview` since now we have two types of diagrams: chord and edge bundling.
> application/org.openjdk.jmc.flightrecorder.hierarchical-edge/src/main/resources/hierarchical-edge.js line 2:
>
>> 1: function updateGraph(eventsJson) {
>> 2: const data = JSON.parse(eventsJson);
>
> First part here is indented with tabs. The rest with spaces. JMC uses 1-tab, 1-level-indent. (Yup, I know that we may be failing this in other parts of our JS code.)
Fixed, now all JS files should have tab indentation.
-------------
PR: https://git.openjdk.org/jmc/pull/405
More information about the jmc-dev
mailing list