RFR: 7831: Add new view for hierarchical edge bundling
Marcus Hirt
hirt at openjdk.org
Thu Aug 4 13:09:15 UTC 2022
On Tue, 28 Jun 2022 13:18:45 GMT, Brice Dutheil <duke at openjdk.org> wrote:
> Joint effort with @cimi to provide _hierarchical edge_ visualization to JMC.
>
> 
>
> Here when the mouse hovers `java.util.concurrent` on the bottom right. One can see the relations with other packages.
>
>
> Based on the preliminary work of @cimi here : https://observablehq.com/@cimi/jfr-graph-hierarchical-edge-bundling
@cimi is adding alternative visualization for chord dependency diagrams towards the end of this week, and then we'll take the changes for 8.3.0.
application/org.openjdk.jmc.feature.flightrecorder/feature.xml line 203:
> 201:
> 202: <plugin
> 203: id="org.openjdk.jmc.flightrecorder.hierarchical-edge"
Nit: I'd prefer to skip the dash.
application/org.openjdk.jmc.feature.flightrecorder/feature.xml line 203:
> 201:
> 202: <plugin
> 203: id="org.openjdk.jmc.flightrecorder.hierarchical-edge"
Nit: I'd prefer skipping the dash.
application/org.openjdk.jmc.flightrecorder.hierarchical-edge/src/main/resources/hierarchical-edge.js line 1:
> 1: function updateGraph(eventsJson) {
First part here is indented with tabs. The rest with spaces. JMC uses 1-tab, 1-level-indent. (Yup, I know that we may be failing this in other parts of our JS code.)
application/org.openjdk.jmc.flightrecorder.hierarchical-edge/src/main/resources/hierarchical-edge.js line 2:
> 1: function updateGraph(eventsJson) {
> 2: const data = JSON.parse(eventsJson);
First part here is indented with tabs. The rest with spaces. JMC uses 1-tab, 1-level-indent. (Yup, I know that we may be failing this in other parts of our JS code.)
-------------
PR: https://git.openjdk.org/jmc/pull/405
More information about the jmc-dev
mailing list