RFR: 7526: JMC not buildable with jdk17 [v2]

Patrick Reinhart reinhapa at openjdk.java.net
Mon Jan 17 19:05:34 UTC 2022


On Mon, 17 Jan 2022 17:16:54 GMT, Johannes Bechberger <duke at openjdk.java.net> wrote:

>> Tested on Java 11 x86 and aarch64 (azul, but only builds), and on Java 17 x86 and aarch64.
>
> Johannes Bechberger has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix maven cache directories in GitHub actions

Changes requested by reinhapa (Committer).

.github/workflows/validate.yml line 155:

> 153:     - name: Run agent tests
> 154:       run: .\scripts\runagenttests.bat
> 155:       shell: cmd

This could be solved by define an according matrix definition and using `{{ matrix.jdk }}` in the respective places

    strategy:
      matrix:
        jdk: ['11', '17']

 Here the example for the `linux` build step:


jobs:
  linux:
    strategy:
      matrix:
        jdk: ['11', '17']
    runs-on: 'ubuntu-latest'
    steps:
    - uses: actions/checkout at v1
    - uses: actions/setup-java at v1
      with:
        java-version: {{ matrix.jdk }}
        java-package: jdk
    - name: Cache local Maven repository
      uses: actions/cache at v2
      with:
        path: ~/.m2/repository
        key: ${{ runner.os }}-maven-${{ hashFiles('**/pom.xml') }}
        restore-keys: |
          ${{ runner.os }}-maven-
    - name: Check formatting
      run: ./scripts/checkformatting.sh
    - name: Run core tests
      run: ./scripts/runcoretests.sh
    - name: Run application tests
      run: ./scripts/runapptests.sh
    - name: Run agent tests
      run: ./scripts/runagenttests.sh

-------------

PR: https://git.openjdk.java.net/jmc/pull/363


More information about the jmc-dev mailing list