RFR: 7526: JMC not buildable with jdk17 [v2]
Johannes Bechberger
duke at openjdk.java.net
Tue Jan 18 08:32:27 UTC 2022
On Mon, 17 Jan 2022 19:02:13 GMT, Patrick Reinhart <reinhapa at openjdk.org> wrote:
>> Johannes Bechberger has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Fix maven cache directories in GitHub actions
>
> .github/workflows/validate.yml line 155:
>
>> 153: - name: Run agent tests
>> 154: run: .\scripts\runagenttests.bat
>> 155: shell: cmd
>
> This could be solved by define an according matrix definition and using `{{ matrix.jdk }}` in the respective places
>
> strategy:
> matrix:
> jdk: ['11', '17']
>
> Here the example for the `linux` build step:
>
>
> jobs:
> linux:
> strategy:
> matrix:
> jdk: ['11', '17']
> runs-on: 'ubuntu-latest'
> steps:
> - uses: actions/checkout at v1
> - uses: actions/setup-java at v1
> with:
> java-version: {{ matrix.jdk }}
> java-package: jdk
> - name: Cache local Maven repository
> uses: actions/cache at v2
> with:
> path: ~/.m2/repository
> key: ${{ runner.os }}-maven-${{ hashFiles('**/pom.xml') }}
> restore-keys: |
> ${{ runner.os }}-maven-
> - name: Check formatting
> run: ./scripts/checkformatting.sh
> - name: Run core tests
> run: ./scripts/runcoretests.sh
> - name: Run application tests
> run: ./scripts/runapptests.sh
> - name: Run agent tests
> run: ./scripts/runagenttests.sh
Thanks, I thought about the possibility, but forgot that it was that easy
-------------
PR: https://git.openjdk.java.net/jmc/pull/363
More information about the jmc-dev
mailing list