RFR: 7539: JDP Tests failing in VPN environments
Johannes Bechberger
duke at openjdk.java.net
Fri Jan 21 15:01:47 UTC 2022
On Fri, 21 Jan 2022 14:49:51 GMT, Christoph Langer <clanger at openjdk.org> wrote:
>> Only run broadcasting related tests when supported.
>> Tested on Mac M1 with and without VPN.
>
> core/tests/org.openjdk.jmc.jdp.test/src/test/java/org/openjdk/jmc/jdp/client/TestToolkit.java line 72:
>
>> 70: }
>> 71: TEST_MULTICAST_ADDRESS = tmp;
>> 72: BROADCASTING_SUPPORTED = isBroadcastingSupported();
>
> Hm, I'm wondering whether this broadcasting check should be done in the static initialization of the class... maybe not. Rather do it lazily when calling isBroadcastingSupported()? There are a few tests which don't need this...
The class is only used in this package and half of the test classes in this package need to functionality for their test.
There are 4 test classes overall.
-------------
PR: https://git.openjdk.java.net/jmc/pull/369
More information about the jmc-dev
mailing list