RFR: 7539: JDP Tests failing in VPN environments
Marcus Hirt
hirt at openjdk.java.net
Fri Jan 21 15:14:49 UTC 2022
On Fri, 21 Jan 2022 14:25:16 GMT, Johannes Bechberger <duke at openjdk.java.net> wrote:
> Only run broadcasting related tests when supported.
> Tested on Mac M1 with and without VPN.
I think it would be better to have the test provide information about how to properly configure the machine to properly run the tests than to automatically skip the tests. Perhaps we could also add a system property check or something to make it easy to skip the test from the command line, if someone truly can't get it to work. But then it should be a conscious choice, not something happening automatically to avoid having to fix the setup.
Here is for example one possible scenario if we go with automated skipping:
1. Images used for our automated testing change their configuration, no longer providing a route for local multicast.
2. Tests are automatically skipped.
3. JDP changes and breaks.
4. We are never the wiser (until some JDP using person complains post release).
We shouldn't automatically skip tests without a very strong reason. It's better to inform the runner of the test how to fix their config.
-------------
PR: https://git.openjdk.java.net/jmc/pull/369
More information about the jmc-dev
mailing list