RFR: JMC-7798: Make the frame type extensible [v3]

Marcus Hirt hirt at openjdk.java.net
Sun May 29 15:07:47 UTC 2022


On Wed, 25 May 2022 16:18:59 GMT, Jaroslav Bachorik <jbachorik at openjdk.org> wrote:

>> This change allows the JMC parser users to consume frames with the type set to non-standard values (eg. from async-profiler).
>> 
>> The hard-wired enum approach is replaced with a hybrid solution keeping the standard types in enum-like structure and using a cache for the non-standard types. This allows being fairly flexible when dealing with new frame types while keeping full backward compatibility.
>
> Jaroslav Bachorik has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Addressing review comments

Right now the expected behaviour of a series of poison pills defining ever new frame types is OOME. How about instead having a fixed size LRU cache, or even simply just clear the thing when full and start over?

-------------

PR: https://git.openjdk.java.net/jmc/pull/401


More information about the jmc-dev mailing list