RFR: 7879: Automated Analysis taking very long time to produce results for Class Leak Rule and showing wrong results.
Brice Dutheil
bdutheil at openjdk.org
Wed Oct 5 11:03:36 UTC 2022
On Mon, 26 Sep 2022 18:26:23 GMT, Henrik Dafgård <hdafgard at openjdk.org> wrote:
>> This PR takes care of optimizing and correcting the Class leak rule results on Automated Analysis Page.
>
> core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/general/ClassLeakingRule.java line 108:
>
>> 106: Messages.getString(Messages.ClassLeakingRule_CONFIG_CALCULATION_TIMEOUT),
>> 107: Messages.getString(Messages.ClassLeakingRule_CONFIG_CALCULATION_TIMEOUT_LONG), NUMBER,
>> 108: NUMBER_UNITY.quantity(5));
>
> Nit: The timeout value should be a timestamp instead.
Why not `TIMESPAN`, `MINUTE.quantity(5)` ?
-------------
PR: https://git.openjdk.org/jmc/pull/419
More information about the jmc-dev
mailing list