RFR: 7879: Automated Analysis taking very long time to produce results for Class Leak Rule and showing wrong results. [v3]

Thu Oct 6 12:03:17 UTC 2022

On Wed, 5 Oct 2022 09:38:57 GMT, Brice Dutheil <bdutheil at openjdk.org> wrote:

>> core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/general/ClassLeakingRule.java line 108:
>> 
>>> 106: 			Messages.getString(Messages.ClassLeakingRule_CONFIG_CALCULATION_TIMEOUT),
>>> 107: 			Messages.getString(Messages.ClassLeakingRule_CONFIG_CALCULATION_TIMEOUT_LONG), NUMBER,
>>> 108: 			NUMBER_UNITY.quantity(5));
>> 
>> Nit: The timeout value should be a timestamp instead.
>
> Why not `TIMESPAN`, `MINUTE.quantity(5)` ?

🤦 
Of course that's right, a timespan is the correct type here.

-------------

PR: https://git.openjdk.org/jmc/pull/419