RFR: 8050: JMC Automated Analysis should improve the messages when ignoring to evaluate some rules.

Marcus Hirt hirt at openjdk.org
Tue Apr 25 10:31:14 UTC 2023


On Mon, 24 Apr 2023 00:37:35 GMT, Suchita Chaturvedi <schaturvedi at openjdk.org> wrote:

> One of our customers requested to see a detailed _Ignore Reason_ whenever we ignore any rule in JMC. Rather than just saying Ignored. As part of this PR, we have added a new field Ignored Reason which will be displayed for all the Ignored Rules. It will give a clear idea about the missing event availability requirement.
> 
> The Automated Analysis screen will look like this:
> ![image](https://user-images.githubusercontent.com/11155712/233875905-f70cf844-e9b3-405d-a9be-12a169abfaf1.png)
> 
> In the above screenshot, there are few rules which are Ignored and the corresponding reasons are mentioned.
> 
> Please review the PR and let me know your review comments.

I think the first thing you'd want to know is what you can do to make the rule be evaluated in the future. I think fail fast is still a good idea, though. Perhaps we can capture at least the first reason it failed? Something along the lines of:

So first recording might be:

"The rule wasn't evaluated since the event type A wasn't enabled.

The requirements for this rule is:
* Event A is ENABLED
* Event B is AVAILABLE
* Event C is AVAILABLE"

Then, after enabling A, and getting no events of type C:

"The rule wasn't evaluated since no events of type C could be found, even though it was enabled.

The requirements for this rule is:
* Event A is ENABLED
* Event B is AVAILABLE
* Event C is AVAILABLE"

WDYT?

-------------

PR Comment: https://git.openjdk.org/jmc/pull/481#issuecomment-1521550990


More information about the jmc-dev mailing list