RFR: 8050: JMC Automated Analysis should improve the messages when ignoring to evaluate some rules.

Suchita Chaturvedi schaturvedi at openjdk.org
Tue Apr 25 11:52:12 UTC 2023


On Mon, 24 Apr 2023 00:37:35 GMT, Suchita Chaturvedi <schaturvedi at openjdk.org> wrote:

> One of our customers requested to see a detailed _Ignore Reason_ whenever we ignore any rule in JMC. Rather than just saying Ignored. As part of this PR, we have added a new field Ignored Reason which will be displayed for all the Ignored Rules. It will give a clear idea about the missing event availability requirement.
> 
> The Automated Analysis screen will look like this:
> ![image](https://user-images.githubusercontent.com/11155712/233875905-f70cf844-e9b3-405d-a9be-12a169abfaf1.png)
> 
> In the above screenshot, there are few rules which are Ignored and the corresponding reasons are mentioned.
> 
> Please review the PR and let me know your review comments.

Sounds good. But in the actual JFRs there are 5 values of status possible and we will have to create several meaningful messages based on permutation and combinations.
These are the 5 possible values with their meanings:
AVAILABLE(4) : The type has events available in the collection.
ENABLED(3) : The type was actively enabled in the collection.
DISABLED(2) : The type was actively disabled in the collection.
NONE(1) : The type is known in the collection, but no events were found.
UNKNOWN(0) : The type is unknown in the collection.

-------------

PR Comment: https://git.openjdk.org/jmc/pull/481#issuecomment-1521655240


More information about the jmc-dev mailing list