RFR: 8150: SpotBugs entry in .gitignore hides flightrecorder.configuration files
Christoph Langer
clanger at openjdk.org
Tue Dec 5 08:00:47 UTC 2023
On Mon, 4 Dec 2023 18:50:02 GMT, Alex Macdonald <aptmac at openjdk.org> wrote:
> This PR addresses JMC-8150 [[0]](https://bugs.openjdk.org/browse/JMC-8150), in which the .gitignore entry to ignore the spotbugs generated configuration directories inadvertently ignores the files under `core/org.openjdk.jmc.flightrecorder.configuration/java/org/openjdk/jmc/flightrecorder/configuration`.
>
> I noticed this when VSCode wasn't showing any of the flightrecorder.configuration files in my local file search, and it turns out that VSCode takes the .gitignore file into consideration when scanning for local files.
>
> When running spotbugs on my Windows machine I see a bunch of generated directories which is what this .gitignore entry was aiming to ignore.
>
> Example of generated directories:
> 
>
> This PR simply changes the current `**/configuration/` to `**/configuration/spotbugs` to make it more specific.
>
> [0] https://bugs.openjdk.org/browse/JMC-8150
Looks good and trivial
-------------
Marked as reviewed by clanger (Committer).
PR Review: https://git.openjdk.org/jmc/pull/535#pullrequestreview-1764236210
More information about the jmc-dev
mailing list