Integrated: 8150: SpotBugs entry in .gitignore hides flightrecorder.configuration files

Alex Macdonald aptmac at openjdk.org
Tue Dec 5 12:00:50 UTC 2023


On Mon, 4 Dec 2023 18:50:02 GMT, Alex Macdonald <aptmac at openjdk.org> wrote:

> This PR addresses JMC-8150 [[0]](https://bugs.openjdk.org/browse/JMC-8150), in which the .gitignore entry to ignore the spotbugs generated configuration directories inadvertently ignores the files under `core/org.openjdk.jmc.flightrecorder.configuration/java/org/openjdk/jmc/flightrecorder/configuration`.
> 
> I noticed this when VSCode wasn't showing any of the flightrecorder.configuration files in my local file search, and it turns out that VSCode takes the .gitignore file into consideration when scanning for local files.
> 
> When running spotbugs on my Windows machine I see a bunch of generated directories which is what this .gitignore entry was aiming to ignore.
> 
> Example of generated directories:
> ![Screenshot from 2023-12-04 13-48-35](https://github.com/openjdk/jmc/assets/10425301/2dc857a1-cabe-4845-8f6b-518889a900c6)
> 
> This PR simply changes the current `**/configuration/` to `**/configuration/spotbugs` to make it more specific.
> 
> [0] https://bugs.openjdk.org/browse/JMC-8150

This pull request has now been integrated.

Changeset: 5d6d928d
Author:    Alex Macdonald <aptmac at openjdk.org>
URL:       https://git.openjdk.org/jmc/commit/5d6d928dc84a9a574978dc6bb66aeb532e44eb01
Stats:     1 line in 1 file changed: 0 ins; 0 del; 1 mod

8150: SpotBugs entry in .gitignore hides flightrecorder.configuration files

Reviewed-by: clanger

-------------

PR: https://git.openjdk.org/jmc/pull/535


More information about the jmc-dev mailing list