RFR: 7951: Factor out commonly used test helper classes from org.openjdk.jmc.common.test into dedicated test library module [v2]

[Christoph Langer]

On Fri, 17 Feb 2023 11:58:56 GMT, Brice Dutheil <bdutheil at openjdk.org> wrote:

>> Christoph Langer has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits:
>> 
>>  - Merge branch 'master' into JMC-7951
>>  - JMC-7951
>
> core/tests/org.openjdk.jmc.testlib/src/main/java/org/openjdk/jmc/test/MCTestCase.java line 33:
> 
>> 31:  * WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
>> 32:  */
>> 33: package org.openjdk.jmc.test;
> 
> nitpick: I think the package name should follow the artifact name, maybe something like :
> 
> Suggestion:
> 
> package org.openjdk.jmc.test.lib;

Hm, that would be possible but it would render the change a lot larger. There are also subpackages `io` and `mock.item`. If we were to rename all 3 packages we'd probably have to touch more tests. So, if we opt to rename the packages I'd prefer to do it in a separate PR.

-------------

PR: https://git.openjdk.org/jmc/pull/451