RFR: 7951: Factor out commonly used test helper classes from org.openjdk.jmc.common.test into dedicated test library module [v2]

Brice Dutheil bdutheil at openjdk.org
Mon Feb 20 22:39:34 UTC 2023


On Mon, 20 Feb 2023 18:31:55 GMT, Christoph Langer <clanger at openjdk.org> wrote:

>> core/tests/org.openjdk.jmc.testlib/src/main/java/org/openjdk/jmc/test/MCTestCase.java line 33:
>> 
>>> 31:  * WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
>>> 32:  */
>>> 33: package org.openjdk.jmc.test;
>> 
>> nitpick: I think the package name should follow the artifact name, maybe something like :
>> 
>> Suggestion:
>> 
>> package org.openjdk.jmc.test.lib;
>
> Hm, that would be possible but it would render the change a lot larger. There are also subpackages `io` and `mock.item`. If we were to rename all 3 packages we'd probably have to touch more tests. So, if we opt to rename the packages I'd prefer to do it in a separate PR.

Ok, I understand the concern.

-------------

PR: https://git.openjdk.org/jmc/pull/451


More information about the jmc-dev mailing list