RFR: 8113: Make JfrWizardTest.verifyMinimalRecordingEventSettings work again
Vincent Alexander Beelte
duke at openjdk.org
Thu Jul 27 12:58:50 UTC 2023
On Thu, 27 Jul 2023 10:30:21 GMT, Christoph Langer <clanger at openjdk.org> wrote:
>> One test I see failing all the time when I run the ui tests for my other pull requst is JfrWizardTest.verifyMinimalRecordingEventSettings.
>>
>> It looks to my like the issue is that the event groups must have chaged from when the test was written.
>> Here is what that looks like currently for me on Windows with a jdk 17.0.7
>> 
>> The Java Development Kit group is not explicitly disabled by the test and so it always fails when it tries to assert that only the "Flight Recorder">"Recording Setting" Event is enabled.
>>
>> I changed the test so that is does not need to explicitly disable other groups by name. I think even if for some reason this test failing is a result of my setup on this computer, this way is more robust to changes in the groups.
>
> application/uitests/org.openjdk.jmc.test.jemmy/src/main/java/org/openjdk/jmc/test/jemmy/misc/wrappers/JfrWizard.java line 465:
>
>> 463: final var eventSettingsTree = getEventSettingsTree();
>> 464: final var names = eventSettingsTree.getAllItemTexts();
>> 465: for (var name : names) {
>
> You could simply do `for (var name : getEventSettingsTree().getAllItemTexts()) {` here
Yes I know. There was a version of this where I first also used the eventSettingsTree to select the path. But I removed that because it turned out to not be needed.
-------------
PR Review Comment: https://git.openjdk.org/jmc/pull/509#discussion_r1276243367
More information about the jmc-dev
mailing list