RFR: 8113: Make JfrWizardTest.verifyMinimalRecordingEventSettings work again

[Vincent Alexander Beelte]

On Thu, 27 Jul 2023 10:29:27 GMT, Christoph Langer <clanger at openjdk.org> wrote:

>> One test I see failing all the time when I run the ui tests for my other pull requst is JfrWizardTest.verifyMinimalRecordingEventSettings.
>> 
>> It looks to my like the issue is that the event groups must have chaged from when the test was written.
>> Here is what that looks like currently for me on Windows with a jdk 17.0.7
>> ![JDK Mission Control 21 07 2023 20_13_20](https://github.com/openjdk/jmc/assets/917408/faa65318-5dd6-492b-ae2a-b5f4936a1f9d)
>> The Java Development Kit group is not explicitly disabled by the test and so it always fails when it tries to assert that only the "Flight Recorder">"Recording Setting" Event is enabled.
>> 
>> I changed the test so that is does not need to explicitly disable other groups by name. I think even if for some reason this test failing is a result of my setup on this computer, this way is more robust to changes in the groups.
>
> application/uitests/org.openjdk.jmc.test.jemmy/src/main/java/org/openjdk/jmc/test/jemmy/misc/wrappers/JfrWizard.java line 469:
> 
>> 467: 				setEventSetting(!desiredState, settingName, currentPath);
>> 468: 			}
>> 469: 		}
> 
> Why are you using these additional block braces here?

The block delimits the part that deals with inverting everything before setting the actual path to the desired value. I wanted to give it more structure than just writing it inline but I also felt it is overkill to extract that part into another method.

-------------

PR Review Comment: https://git.openjdk.org/jmc/pull/509#discussion_r1276250188