RFR: 8113: Make JfrWizardTest.verifyMinimalRecordingEventSettings work again [v2]

Thu Jul 27 13:48:53 UTC 2023

On Thu, 27 Jul 2023 13:02:10 GMT, Vincent Alexander Beelte <duke at openjdk.org> wrote:

>> application/uitests/org.openjdk.jmc.test.jemmy/src/main/java/org/openjdk/jmc/test/jemmy/misc/wrappers/JfrWizard.java line 469:
>> 
>>> 467: 				setEventSetting(!desiredState, settingName, currentPath);
>>> 468: 			}
>>> 469: 		}
>> 
>> Why are you using these additional block braces here?
>
> The block delimits the part that deals with inverting everything before setting the actual path to the desired value. I wanted to give it more structure than just writing it inline but I also felt it is overkill to extract that part into another method.

OK, I personally don't like the block but again, matter of taste.

-------------

PR Review Comment: https://git.openjdk.org/jmc/pull/509#discussion_r1276306276