RFR: 8113: Make JfrWizardTest.verifyMinimalRecordingEventSettings work again [v2]

Vincent Alexander Beelte duke at openjdk.org
Thu Jul 27 13:15:50 UTC 2023


On Thu, 27 Jul 2023 13:11:24 GMT, Vincent Alexander Beelte <duke at openjdk.org> wrote:

>> One test I see failing all the time when I run the ui tests for my other pull requst is JfrWizardTest.verifyMinimalRecordingEventSettings.
>> 
>> It looks to my like the issue is that the event groups must have chaged from when the test was written.
>> Here is what that looks like currently for me on Windows with a jdk 17.0.7
>> ![JDK Mission Control 21 07 2023 20_13_20](https://github.com/openjdk/jmc/assets/917408/faa65318-5dd6-492b-ae2a-b5f4936a1f9d)
>> The Java Development Kit group is not explicitly disabled by the test and so it always fails when it tries to assert that only the "Flight Recorder">"Recording Setting" Event is enabled.
>> 
>> I changed the test so that is does not need to explicitly disable other groups by name. I think even if for some reason this test failing is a result of my setup on this computer, this way is more robust to changes in the groups.
>
> Vincent Alexander Beelte has updated the pull request incrementally with one additional commit since the last revision:
> 
>   add 2023 to copyright headers

I am not quite sure if updating the copyright years is done manually but for just now I just added 2023 like I saw it done in one of the other pull requests here.

-------------

PR Comment: https://git.openjdk.org/jmc/pull/509#issuecomment-1653604577


More information about the jmc-dev mailing list