RFR: 8113: Make JfrWizardTest.verifyMinimalRecordingEventSettings work again [v2]
Christoph Langer
clanger at openjdk.org
Thu Jul 27 13:48:49 UTC 2023
On Thu, 27 Jul 2023 13:11:24 GMT, Vincent Alexander Beelte <duke at openjdk.org> wrote:
>> One test I see failing all the time when I run the ui tests for my other pull requst is JfrWizardTest.verifyMinimalRecordingEventSettings.
>>
>> It looks to my like the issue is that the event groups must have chaged from when the test was written.
>> Here is what that looks like currently for me on Windows with a jdk 17.0.7
>> 
>> The Java Development Kit group is not explicitly disabled by the test and so it always fails when it tries to assert that only the "Flight Recorder">"Recording Setting" Event is enabled.
>>
>> I changed the test so that is does not need to explicitly disable other groups by name. I think even if for some reason this test failing is a result of my setup on this computer, this way is more robust to changes in the groups.
>
> Vincent Alexander Beelte has updated the pull request incrementally with one additional commit since the last revision:
>
> add 2023 to copyright headers
Copyright years update is correct, so from my end good to go, too.
-------------
Marked as reviewed by clanger (Committer).
PR Review: https://git.openjdk.org/jmc/pull/509#pullrequestreview-1549885982
More information about the jmc-dev
mailing list