RFR: 7894: Provide an alternative Java based flamegraph visualization [v12]

[Brice Dutheil]

On Thu, 8 Jun 2023 15:09:28 GMT, Brice Dutheil <bdutheil at openjdk.org> wrote:

>> This change introduces a possible replacement for the current flamegraph view.
>> 
>> **Motivation**
>> The current is based on a web view. In the current state, 
>> - the web view can be slow to render especially when the tree is large.
>> - the web view don't feel well integrated, in particular when popups are shown.
>> - web view are difficult to work with from a JMC developer perspective.
>> 
>> ![image](https://user-images.githubusercontent.com/803621/177537938-423a4d53-c2ac-4c56-8583-abe4cc910e37.png)
>> 
>> **Description**
>> Concretely this PR relies on the swing component to render flamegraphs : https://github.com/bric3/fireplace. And plays with the bridge between SWT and AWT via the `SWT_AWT` class.
>> 
>> As the intent of this view is to eventually replace the current one, the icons are the same.
>> 
>> Since fireplace has no actual release, only snapshots, in order to try this PR, it is necessary to install the snapshot manually before starting the p2 server.
>> 
>> 
>> cd releng/third-party
>> 
>> mvn dependency:get -DrepoUrl=https://s01.oss.sonatype.org/content/repositories/snapshots -Dartifact=io.github.bric3.fireplace:fireplace-swing:0.0.1-SNAPSHOT:jar
>> 
>> # if sources are wanted
>> mvn dependency:get -DrepoUrl=https://s01.oss.sonatype.org/content/repositories/snapshots -Dartifact=io.github.bric3.fireplace:fireplace-swing:0.0.1-SNAPSHOT:jar:sources
>> 
>> # make the p2 site, don't forget the -U
>> mvn p2:site -U; mvn jetty:run
>> 
>> 
>> **Outstanding issues / limitation**
>> - [x] Fireplace has not yet a stable release as some part of its API are a bit rough.
>> - [x] Currently the view does not initializes correctly:
>>    the swing `JScrollPane` don't show scroll bars, until the view is resized by the user. I lack the SWT / Swing expertise to understand why at this time.
>>    https://github.com/bric3/fireplace/issues/79
>> - [x] Fireplace only supports _icicle_ view at this time.
>>    https://github.com/bric3/fireplace/issues/22
>> - [x] Icons for minimap toggle and zoom reset
>>    <img width="237" alt="image" src="https://user-images.githubusercontent.com/803621/183126781-07af0e94-a5d5-458c-97e3-a5e012177248.png">
>> - [x] Export to image
>>    https://github.com/bric3/fireplace/issues/99
>> - [x] Export to print ?
>>    Can be done at a later time
>> - [x] release of fireplace
>
> Brice Dutheil has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Bump copright year to 2023
>  - Use JavaSE-17

1. > I'd have to take a bit more a look if it's just me, but I don't have any tooltips displayed when hovering the graph lanes.

   Those are showing fine on macOs, regardless it's an eclipse plugin or a standalone app. I don't have a windows under the hod so I don't know.

2. > Maybe there's a way to distinguish this new flame view from the old one? When adding it to the view it might not be intuitive which one to pick, "Flame View vs. Flame Graph View"

   I think the view should replace the old one at some point. Currently I think the view should be tested to see what's missing before make it a "drop-in" replacement.

3. > The save feature is saving an empty file for me.

   Well spotted this only happens on the jpeg format, png works fine.

-------------

PR Comment: https://git.openjdk.org/jmc/pull/408#issuecomment-1583197872