RFR: 7894: Provide an alternative Java based flamegraph visualization [v20]

[Brice Dutheil]

On Sun, 11 Jun 2023 20:18:48 GMT, Christoph Langer <clanger at openjdk.org> wrote:

>> Brice Dutheil has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   fix: Make spotless happy
>
> application/org.openjdk.jmc.flightrecorder.flamegraph/build.properties line 1:
> 
>> 1: source.. = src/main/java/
> 
> Any particular reason why src/main/resources is missing here now?

I'm not sure, I never manually touched that file. It's odd indeed I'll add it back.

> application/org.openjdk.jmc.flightrecorder.flamegraph/plugin.properties line 3:
> 
>> (failed to retrieve contents of file, check the PR for context)
> Since you merely move the files from one project to another, wouldn't it be more appropriate to use copyright `...2019, 2023, ...` here?

Actually I didn't move them. Those are new files, but git must detect a rename somehow since I deleted the old plugin in https://github.com/openjdk/jmc/pull/408/commits/b94e708c9abc3f3179bdf013d6f88e6fd592d370.
I can add a rage, but this feels overzealous.

> application/org.openjdk.jmc.flightrecorder.flamegraph/plugin.xml line 3:
> 
>> 1: <?xml version="1.0" encoding="UTF-8"?>
>> 2: <!--
>> 3:    Copyright (c) 2023, Oracle and/or its affiliates. All rights reserved.
> 
> Same here.

Same as above

> application/org.openjdk.jmc.flightrecorder.flamegraph/pom.xml line 54:
> 
>> 52: 		<plugins>
>> 53: 		</plugins>
>> 54: 	</build>
> 
> I guess the build section is not necessary here

Ah yes good call, thanks.

> releng/platform-definitions/platform-definition-2022-09/pom.xml line 3:
> 
>> 1: <?xml version="1.0" encoding="UTF-8"?>
>> 2: <!--
>> 3:    Copyright (c) 2022, 2023, Oracle and/or its affiliates. All rights reserved.
> 
> Not necessary, no change in file.

Ah indeed it was necessary as I added a custom repository in the past but it has been removed along the way.

-------------

PR Review Comment: https://git.openjdk.org/jmc/pull/408#discussion_r1226594684
PR Review Comment: https://git.openjdk.org/jmc/pull/408#discussion_r1226597792
PR Review Comment: https://git.openjdk.org/jmc/pull/408#discussion_r1226600269
PR Review Comment: https://git.openjdk.org/jmc/pull/408#discussion_r1226600604
PR Review Comment: https://git.openjdk.org/jmc/pull/408#discussion_r1226602377