RFR: 7894: Provide an alternative Java based flamegraph visualization [v21]

Brice Dutheil bdutheil at openjdk.org
Mon Jun 12 22:16:00 UTC 2023


On Mon, 12 Jun 2023 12:32:25 GMT, Brice Dutheil <bdutheil at openjdk.org> wrote:

>> application/org.openjdk.jmc.flightrecorder.flamegraph/plugin.properties line 3:
>> 
>>> (failed to retrieve contents of file, check the PR for context)
>> Since you merely move the files from one project to another, wouldn't it be more appropriate to use copyright `...2019, 2023, ...` here?
>
> Actually I didn't move them. Those are new files, but git must detect a rename somehow since I deleted the old plugin in https://github.com/openjdk/jmc/pull/408/commits/b94e708c9abc3f3179bdf013d6f88e6fd592d370.
> I can add a range, but this feels overzealous.

Sorry for the typo 😅

-------------

PR Review Comment: https://git.openjdk.org/jmc/pull/408#discussion_r1227293897


More information about the jmc-dev mailing list