RFR: 8090: Enhancements for agent pom
Christoph Langer
clanger at openjdk.org
Wed Jun 14 18:06:08 UTC 2023
On Wed, 14 Jun 2023 14:02:23 GMT, Alex Macdonald <aptmac at openjdk.org> wrote:
>> This is the cleanup for JMC agent in the sense of #495.
>>
>> It contains:
>> - version bumps
>> - URL updates
>> - spotless integration
>
> agent/pom.xml line 81:
>
>> 79: <jmc.config.path>${project.basedir}/../configuration</jmc.config.path>
>> 80: <!-- Plugin Versions -->
>> 81: <maven.checkstyle.version>3.3.0</maven.checkstyle.version>
>
> Overall the changes look good to me, but while you're here changing the pom, what are your thoughts on alphabetical ordering the plugins?
Well, alphabetical ordering could be an idea. Or maybe ordering in the order that plugins appear in the build - although this is difficult since certain plugins might appear in different phases. So, maybe alphabetical ordering would be good. But I would defer this to another PR.
-------------
PR Review Comment: https://git.openjdk.org/jmc/pull/496#discussion_r1229987831
More information about the jmc-dev
mailing list