RFR: 8055: Improvement in stacktrace view for Duration [v2]

[Brice Dutheil]

On Thu, 18 May 2023 08:26:02 GMT, Suchita Chaturvedi <schaturvedi at openjdk.org> wrote:

>> 1. Added a new column for Duration. It will be populated only when the "Show Duration" toggle icon is clicked. Not by default.
>> 2. Fixed NaN issue for screens where duration is not present.
>> 3. Added timeunit to make tooltip more meaningful.
>> 
>> Please refer JIRA description for more details.
>
> Suchita Chaturvedi has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Removed unused method

Marked as reviewed by bdutheil (Author).

application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/messages/internal/Messages.java line 655:

> 653: 		double duration, String durationUnit, double totalDuration, String totalDurationUnit, String frameFraction) {
> 654: 		String message;
> 655: 		if (duration == 1) {

- You didn't change thus part if the code but I think this could be written `1.0` or `1d` as `duration` is a double.

-------------

PR Review: https://git.openjdk.org/jmc/pull/475#pullrequestreview-1432290081
PR Review Comment: https://git.openjdk.org/jmc/pull/475#discussion_r1197557545