RFR: 8055: Improvement in stacktrace view for Duration [v2]

[Christoph Langer]

On Thu, 18 May 2023 08:26:02 GMT, Suchita Chaturvedi <schaturvedi at openjdk.org> wrote:

>> 1. Added a new column for Duration. It will be populated only when the "Show Duration" toggle icon is clicked. Not by default.
>> 2. Fixed NaN issue for screens where duration is not present.
>> 3. Added timeunit to make tooltip more meaningful.
>> 
>> Please refer JIRA description for more details.
>
> Suchita Chaturvedi has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Removed unused method

Marked as reviewed by clanger (Committer).

application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/views/stacktrace/StacktraceView.java line 919:

> 917: 				return UnitLookup.PERCENT_UNITY.quantity(duration.doubleValue() / (double) totalDuration.doubleValue())
> 918: 						.displayUsing(IDisplayable.AUTO);
> 919: 			} else

Style nit: Please also use braces for the else part.

-------------

PR Review: https://git.openjdk.org/jmc/pull/475#pullrequestreview-1434852972
PR Review Comment: https://git.openjdk.org/jmc/pull/475#discussion_r1199224736