RFR: 8050: JMC Automated Analysis should improve the messages when ignoring to evaluate some rules. [v2]

[Marcus Hirt]

On Thu, 18 May 2023 12:13:31 GMT, Suchita Chaturvedi <schaturvedi at openjdk.org> wrote:

>> Suchita Chaturvedi has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Implemented the review comments
>
> Implemented all the review comments.
> 
> What's new?
> 1. Introduced a new severity "Ignore" apart from Info, Warning and NA.
> 2. All the ignored rules will be displayed with a label "Ignored". So that the user is clear that this rule is ignored.
> 3. Expand ignored rule to see more info. If user is interested in ignore reason for any particular rule, he/she can expand the rule to see all the reasons for ignoring that rule.
> 4. Introduced a new checkbox at top (Next to Show OK results), Show IGNORED results. The visibility of the ignored rules can be toggled by clicking that button. By default ignored rules wont be visible.
> 
> Few screenshots for better understanding:
> 
> Default screen:
> ![image](https://github.com/openjdk/jmc/assets/11155712/745e6d31-7e42-4f83-be04-cc7ef59e9aa1)
> 
> Show IGNORED Results button placement:
> ![image](https://github.com/openjdk/jmc/assets/11155712/ac07d1f5-5393-4fab-aa37-149242ff2056)
> 
> Click on Show Ignored icon:
> ![image](https://github.com/openjdk/jmc/assets/11155712/c21615e4-1086-421d-96d3-ed1bf2c59bf8)
> 
> Click on Show OK icon also:
> ![image](https://github.com/openjdk/jmc/assets/11155712/4af59a82-2d9b-478d-a988-676d6173867d)
> 
> Uncheck Show Ignore Icon:
> ![image](https://github.com/openjdk/jmc/assets/11155712/20fc68d2-c3ee-44e6-9abe-d4a517a3d73b)
> 
> Description when rule is ignored because of 2 reasons:
> ![image](https://github.com/openjdk/jmc/assets/11155712/e0ea2401-5a42-4960-8149-c221c54886b1)
> 
> Description when rule is ignored because of 1 reason:
> ![image](https://github.com/openjdk/jmc/assets/11155712/d0525b71-29f4-4e09-80b2-be772e8096fc)
> 
> Description when rule is ignored because of 4 reasons:
> ![image](https://github.com/openjdk/jmc/assets/11155712/3b17b7c2-765b-4a0f-824b-ab374b099294)

Looks good! Thank you for your contribution @Suchitainf!

-------------

PR Comment: https://git.openjdk.org/jmc/pull/481#issuecomment-1552995999