RFR: 8055: Improvement in stacktrace view for Duration [v2]

[Alex Macdonald]

On Fri, 19 May 2023 15:57:31 GMT, Alex Macdonald <aptmac at openjdk.org> wrote:

>> Suchita Chaturvedi has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Removed unused method
>
> application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/views/stacktrace/StacktraceView.java line 989:
> 
>> 987: 		Duration rawDuration = null;
>> 988: 		String formattedTime = "NA";
>> 989: 		if (unit.equalsIgnoreCase("ns"))
> 
> Could these be if/else ifs?
> 
> Also is there a particular reason behind checking if it's in ns -> s -> ms, or could it be incremental (ns -> ms -> s)?

Also are these the only possible time formats? I was playing around with some of recordings and on the threads pages the string unit sometimes comes in as ticks, so the duration just lists "NA" in the column (but the percentage by duration column still works).

-------------

PR Review Comment: https://git.openjdk.org/jmc/pull/475#discussion_r1199246743