RFR: 8055: Improvement in stacktrace view for Duration [v2]

[Alex Macdonald]

On Thu, 18 May 2023 08:26:02 GMT, Suchita Chaturvedi <schaturvedi at openjdk.org> wrote:

>> 1. Added a new column for Duration. It will be populated only when the "Show Duration" toggle icon is clicked. Not by default.
>> 2. Fixed NaN issue for screens where duration is not present.
>> 3. Added timeunit to make tooltip more meaningful.
>> 
>> Please refer JIRA description for more details.
>
> Suchita Chaturvedi has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Removed unused method

application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/views/stacktrace/StacktraceView.java line 989:

> 987: 		Duration rawDuration = null;
> 988: 		String formattedTime = "NA";
> 989: 		if (unit.equalsIgnoreCase("ns"))

Could these be if/else ifs?

Also is there a particular reason behind checking if it's in ns -> s -> ms, or could it be incremental (ns -> ms -> s)?

-------------

PR Review Comment: https://git.openjdk.org/jmc/pull/475#discussion_r1199123370