RFR: 8055: Improvement in stacktrace view for Duration [v2]

Alex Macdonald aptmac at openjdk.org
Fri May 19 18:20:02 UTC 2023


On Thu, 18 May 2023 08:26:02 GMT, Suchita Chaturvedi <schaturvedi at openjdk.org> wrote:

>> 1. Added a new column for Duration. It will be populated only when the "Show Duration" toggle icon is clicked. Not by default.
>> 2. Fixed NaN issue for screens where duration is not present.
>> 3. Added timeunit to make tooltip more meaningful.
>> 
>> Please refer JIRA description for more details.
>
> Suchita Chaturvedi has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Removed unused method

application/org.openjdk.jmc.flightrecorder.ui/src/main/resources/org/openjdk/jmc/flightrecorder/ui/messages/internal/messages.properties line 513:

> 511: STACKTRACE_VIEW_SELECTION=Stack Trace View Selection
> 512: STACKTRACE_VIEW_TREE_VIEW=Tree View
> 513: STACKTRACE_VIEW_PERCENTAGE_BY_DURATION=Show Duration

Without the 'Percentage By' portion in the string, should this be something like 'STACKTRACE_VIEW_DURATION' ?

-------------

PR Review Comment: https://git.openjdk.org/jmc/pull/475#discussion_r1199247456


More information about the jmc-dev mailing list