RFR: 7307: Move org.openjdk.jmc.flightrecorder.configuration bundle from application to core [v7]
Marcus Hirt
hirt at openjdk.org
Thu Nov 30 14:59:29 UTC 2023
On Wed, 1 Nov 2023 20:28:36 GMT, Joshua Matsuoka <jmatsuoka at openjdk.org> wrote:
>> This PR addresses JMC-7307 [[0]](https://bugs.openjdk.java.net/browse/JMC-7307), in which it would be helpful to have flightrecorder.configuration distributed in jmc core.
>>
>> This PR continues from #299 , Alex is currently away so I'll be continuing this PR/bug. This PR builds off of Alex's existing branch and preserves the history. It fixes the merge conflicts and addresses the remaining review comments on #299 .
>>
>> [0] https://bugs.openjdk.java.net/browse/JMC-7307
>
> Joshua Matsuoka has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 24 commits:
>
> - Merging changes from upstream
> - Import cleanup
> - Running spotless
> - Removing extraneous merge artifacts
> - Merge remote-tracking branch 'upstream/master' into 7307
> - running spotlesS
> - Fixing merge conflicts
> - Merge remote-tracking branch 'upstream/master' into 7307
> - Fixing manifest
> - Fixing visibility of XML classes
> - ... and 14 more: https://git.openjdk.org/jmc/compare/b0d11227...7904676a
core/org.openjdk.jmc.common/src/main/java/org/openjdk/jmc/common/resource/Resource.java line 38:
> 36: * Class identifying a resource in an Eclipse plugin.
> 37: */
> 38: public class Resource {
Feels a bit weird to have this in common, but I guess it can't easily be helped.
-------------
PR Review Comment: https://git.openjdk.org/jmc/pull/469#discussion_r1410798477
More information about the jmc-dev
mailing list