RFR: 8112: Flamegraph model creation performance improvements [v4]

[Vincent Alexander Beelte]

On Sun, 15 Oct 2023 10:11:49 GMT, Christoph Langer <clanger at openjdk.org> wrote:

>>> I wasn't aware that all of jmc is also published to maven.
>> 
>> Only the core libraries.
>
> Hi, what's the status here? Should we file an issue to revert getNodeId()? Or is it considered alright?

I probably am not going to have time doing anything on this for some time.  
I also I currently think that, while technically one should always stay backwards compatible just to ease migrations and preserve the willingness of users to upgrade, it should be ok in this case. Given the major version jump from 8.x currently published to maven und the development version of 9.0.0 in this repo, which would in theory allow for incompatible changes.

-------------

PR Review Comment: https://git.openjdk.org/jmc/pull/502#discussion_r1359851276