RFR: 8127: Use ProcessHandle API to get PIDs

Christoph Langer clanger at openjdk.org
Sun Oct 15 11:06:20 UTC 2023


On Sun, 15 Oct 2023 10:34:50 GMT, Christoph Langer <clanger at openjdk.org> wrote:

>> Hi,
>> 
>> this PR uses `ProcessHandle.current().pid()` that was introduced in Java 9 rather than parsing the output of `ManagementFactory.getRuntimeMXBean().getName()`.
>> 
>> If you think this is worthwhile, I'd appreciate a ticket and sponsoring.
>> 
>> Cheers,
>> Christoph
>
> @dreis2211, please enable GHA testing to avoid such issues like the checkstyle problems introduced with #518. Thanks.

> @RealCLanger thanks for the review. Is there a problem with this PR? What do you mean by enabling GHA testing? Aren't the Github Actions executed here?

You have to enable actions here: https://github.com/dreis2211/jmc/actions. They are run in your GitHub repository and the OpenJDK Skara bots will pick up the results.

I don't think anything is wrong with this PR, though. But we'll see whether GHA jobs report green result then.

-------------

PR Comment: https://git.openjdk.org/jmc/pull/522#issuecomment-1763354584


More information about the jmc-dev mailing list