RFR: 8054: Support the new JPLIS agent events
Alex Macdonald
aptmac at openjdk.org
Thu Jan 18 18:56:29 UTC 2024
On Thu, 18 Jan 2024 02:37:42 GMT, Marcus Hirt <hirt at openjdk.org> wrote:
> Simple rules + page. Also some minor fixes.
Overall I think it looks good and works well.
I did find that the labels in the configuration are duplicated within each section. For example, both the dynamic agent limit and dynamic native agent limit options have the same short and long description, and this goes for the multiple agent and multiple native agent options as well. These should probably have unique descriptions for clarity.

core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/agent/DynamicallyLoadedAgentsRule.java line 74:
> 72: public static final TypedPreference<IQuantity> JAVA_WARNING_LIMIT = new TypedPreference<>(
> 73: "agents.dynamic.java.warning.limit", //$NON-NLS-1$
> 74: Messages.getString(Messages.DynamicallyLoadedAgentsRule_JAVA_WARNING_LIMIT),
This label for dynamic agent limits is the same as .. (to be continued 8 lines from now)
core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/agent/DynamicallyLoadedAgentsRule.java line 80:
> 78: public static final TypedPreference<IQuantity> NATIVE_WARNING_LIMIT = new TypedPreference<>(
> 79: "agents.dynamic.native.warning.limit", //$NON-NLS-1$
> 80: Messages.getString(Messages.DynamicallyLoadedAgentsRule_JAVA_WARNING_LIMIT),
.. the label for native agent limits. They could benefit from having their own labels and long descriptions.
-------------
Changes requested by aptmac (Reviewer).
PR Review: https://git.openjdk.org/jmc/pull/543#pullrequestreview-1830359074
PR Review Comment: https://git.openjdk.org/jmc/pull/543#discussion_r1457855187
PR Review Comment: https://git.openjdk.org/jmc/pull/543#discussion_r1457855317
More information about the jmc-dev
mailing list