RFR: 8155 eclipse 2023 12 upgrade

[Alex Macdonald]

On Thu, 18 Jan 2024 17:50:13 GMT, Virag Purnam <vpurnam at openjdk.org> wrote:

> Eclipse platform upgrade to 2023-12.
> 
> - javax.inject has been replaced with jakarta.inject.
> - added missing features to target file.
> - upgraded tycho to 3.0.5.
> - upgraded jetty to 10.0.18.

Looks okay to me, just a couple of license headers that could be fixed up. 

There's also an Integration Blocker warning: `Title mismatch between PR and JBS for issue`, when you get the chance the PR title can be updated to match the jira issue.

releng/platform-definitions/platform-definition-2023-12/platform-definition-2023-12.target line 3:

> 1: <?xml version="1.0" encoding="UTF-8" standalone="no"?>
> 2: <!--
> 3:    Copyright (c) 2023, 2024, Oracle and/or its affiliates. All rights reserved.

Doesn't need to start with the 2023, also you've added the Datadog licensing line in below as a heads up.

releng/platform-definitions/platform-definition-2023-12/pom.xml line 3:

> 1: <?xml version="1.0" encoding="UTF-8"?>
> 2: <!--
> 3:    Copyright (c) 2023, 2024, Oracle and/or its affiliates. All rights reserved.

Same as the platform definition, doesn't need the 2023 and you brought in the Datadog line as a heads up.

-------------

PR Review: https://git.openjdk.org/jmc/pull/546#pullrequestreview-1830391471
PR Review Comment: https://git.openjdk.org/jmc/pull/546#discussion_r1457875169
PR Review Comment: https://git.openjdk.org/jmc/pull/546#discussion_r1457875804