RFR: 7455: Add support for jolokia JMX service connection [v16]

[Martin Skarsaune]

On Fri, 7 Jun 2024 14:31:56 GMT, Alex Macdonald <aptmac at openjdk.org> wrote:

>> Martin Skarsaune has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Revert "JMC-7455: Actually measure coverage of jolokia"
>>    
>>    This reverts commit 17a7eaf8e3e8c4da828633d2d0e1484a47cb4ad3.
>>  - Revert "JMC-7455: Attempt to use late property resolution for surefireArgLine"
>>    
>>    This reverts commit 13210f66dcf56f7790d26397ca00ae86acfb58ed.
>
> application/tests/org.openjdk.jmc.jolokia.test/src/test/java/org/openjdk/jmc/jolokia/JolokiaTest.java line 94:
> 
>> 92: 					.getAttributes()) {
>> 93: 				if (!unsafeAttributes.contains(attributeInfo.getName())) {
>> 94: 					System.out.println("Getting attribute " + objectName + "/" + attributeInfo.getName());
> 
> Would prefer to use a logger here, although not completely sure we need to log? Could probably use an assertion to verify the attributes are as expected.

Trying to replace with assertion [WIP]

-------------

PR Review Comment: https://git.openjdk.org/jmc/pull/548#discussion_r1639693997