RFR: 7455: Add support for jolokia JMX service connection [v16]

Martin Skarsaune duke at openjdk.org
Fri Jun 14 17:32:21 UTC 2024


On Fri, 14 Jun 2024 11:36:53 GMT, Martin Skarsaune <duke at openjdk.org> wrote:

>> application/tests/org.openjdk.jmc.jolokia.test/src/test/java/org/openjdk/jmc/jolokia/JolokiaTest.java line 94:
>> 
>>> 92: 					.getAttributes()) {
>>> 93: 				if (!unsafeAttributes.contains(attributeInfo.getName())) {
>>> 94: 					System.out.println("Getting attribute " + objectName + "/" + attributeInfo.getName());
>> 
>> Would prefer to use a logger here, although not completely sure we need to log? Could probably use an assertion to verify the attributes are as expected.
>
> Trying to replace with assertion [WIP]

Done

-------------

PR Review Comment: https://git.openjdk.org/jmc/pull/548#discussion_r1640148385


More information about the jmc-dev mailing list