RFR: 8204 : Keyboard traps in flamegraph view for search option [v2]

Brice Dutheil bdutheil at openjdk.org
Fri Mar 1 16:39:52 UTC 2024


On Fri, 1 Mar 2024 14:33:35 GMT, Alex Macdonald <aptmac at openjdk.org> wrote:

>> I have addressed this and extracted a method.
>
> Reading Brice's comment above, I'm thinking he meant move the `tableInspector.setFocus()` lines into it's own method so there is a centralized location to add a comment as to why this line is needed?
> 
> Something like ..
> 
> // 8204: this set focus is required in order to ..
> private void setFocusOnTableInspector() {
>   tableInspector.setFocus();
> }

That was my original suggestion, but since there's `setFocus` (a single statement), but at the same time it's just a suggestion that does not bring as much value since the goal of `setFocus` is somewhat straightforward.

-------------

PR Review Comment: https://git.openjdk.org/jmc/pull/554#discussion_r1509233631


More information about the jmc-dev mailing list