RFR: 8204 : Keyboard traps in flamegraph view for search option [v2]

Virag Purnam vpurnam at openjdk.org
Sun Mar 3 11:48:51 UTC 2024


On Fri, 1 Mar 2024 16:30:11 GMT, Brice Dutheil <bdutheil at openjdk.org> wrote:

>> Reading Brice's comment above, I'm thinking he meant move the `tableInspector.setFocus()` lines into it's own method so there is a centralized location to add a comment as to why this line is needed?
>> 
>> Something like ..
>> 
>> // 8204: this set focus is required in order to ..
>> private void setFocusOnTableInspector() {
>>   tableInspector.setFocus();
>> }
>
> That was my original suggestion, but since there's `setFocus` (a single statement), but at the same time it's just a suggestion that does not bring as much value since the goal of `setFocus` is somewhat straightforward.

I have added setFocus to Import Button as well as Export Button. I have extracted that to a method now.

-------------

PR Review Comment: https://git.openjdk.org/jmc/pull/554#discussion_r1510246163


More information about the jmc-dev mailing list