RFR: 8254: Allow primitive types in converters

Marcus Hirt hirt at openjdk.org
Mon Sep 9 22:16:09 UTC 2024


On Mon, 9 Sep 2024 14:20:35 GMT, Ralf Schmelter <rschmelter at openjdk.org> wrote:

> This allows primitive types in converters.

Looks good!

agent/src/test/resources/org/openjdk/jmc/agent/converters/test/jfrprobes_template.xml line 347:

> 345: 			<location>WRAP</location>
> 346: 		</event>
> 347: 		<event id="demo.jfr.convertertest.ConverterEventMultiDefaultPrimBoolean">

Might as well spell out Primitive. It's long enough of a name as it is anyways. ;)

-------------

PR Review: https://git.openjdk.org/jmc/pull/584#pullrequestreview-2291042892
PR Review Comment: https://git.openjdk.org/jmc/pull/584#discussion_r1751000281


More information about the jmc-dev mailing list