RFR: 8248: [Accessibility] Low Contrast in High Contrast mode on Stacktrace View [v4]

[Brice Dutheil]

On Mon, 16 Sep 2024 08:16:45 GMT, Suchita Chaturvedi <schaturvedi at openjdk.org> wrote:

>> This PR is to fix the accessibility issue for High Contrast mode. Stracktrace View was not readable at all in dark mode.
>> 
>> Before the fix:
>> <img width="959" alt="image" src="https://github.com/user-attachments/assets/f12f1b7d-aa8a-4cce-8e0c-7731d5f9cc96">
>> 
>> After the fix:
>> <img width="959" alt="image" src="https://github.com/user-attachments/assets/8f7be98a-206b-4758-a1c2-8971d7ab1c55">
>
> Suchita Chaturvedi has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Merge branch '8248' of https://github.com/Suchitainf/jmc into 8248
>  - Resolve Spotbug error

application/org.openjdk.jmc.ui.common/src/main/java/org/openjdk/jmc/ui/common/util/ThemeUtils.java line 37:

> 35: 	private static final double BRIGHTNESS_THRESHOLD = 0.5;
> 36: 
> 37: 	private static void isDarkMode() {

**nitpick:** I'd rename `isDarkMode` that better describe that it updates the state, e.g. 

Suggestion:

	private static void updateCurrentThemeDarkModeStatus() {

-------------

PR Review Comment: https://git.openjdk.org/jmc/pull/580#discussion_r1760739614