RFR: 8248: [Accessibility] Low Contrast in High Contrast mode on Stacktrace View [v4]

[Suchita Chaturvedi]

On Mon, 16 Sep 2024 08:33:02 GMT, Brice Dutheil <bdutheil at openjdk.org> wrote:

>> Suchita Chaturvedi has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Merge branch '8248' of https://github.com/Suchitainf/jmc into 8248
>>  - Resolve Spotbug error
>
> application/org.openjdk.jmc.ui.common/src/main/java/org/openjdk/jmc/ui/common/util/ThemeUtils.java line 37:
> 
>> 35: 	private static final double BRIGHTNESS_THRESHOLD = 0.5;
>> 36: 
>> 37: 	private static void isDarkMode() {
> 
> **nitpick:** I'd rename `isDarkMode` that better describe that it updates the state, e.g. 
> 
> Suggestion:
> 
> 	private static void updateCurrentThemeDarkModeStatus() {

Done.

-------------

PR Review Comment: https://git.openjdk.org/jmc/pull/580#discussion_r1760753795