RFR: 8400: Add more show options for JMX Console graphs [v2]
Marcus Hirt
hirt at openjdk.org
Tue Jul 8 21:38:00 UTC 2025
On Fri, 4 Jul 2025 17:04:00 GMT, Alex Macdonald <aptmac at openjdk.org> wrote:
>> Marcus Hirt has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Spotless
>
> application/org.openjdk.jmc.greychart.ui/src/main/java/org/openjdk/jmc/greychart/ui/views/ChartMenuBuilder.java line 469:
>
>> 467: getShell().setText(Messages.CustomTimeRangeDialog_TITLE);
>> 468: Control contents = super.createContents(parent);
>> 469: contents.getShell().setSize(450, 300);
>
> Gave this a try on my Linux machine, and the controls get cut-off horizontally a bit early. It will need another 100px on the width.
>
> 
>
> An alternative could be to allow these dialogs to be resized. To do so, the `isResizable()` on the dialog class can be overriden as follows:
>
> @Override
> protected boolean isResizable() {
> return true;
> }
A combination seems right - give it a bit more space, and also allow for it to be resized. Also, it should grab the existing space, like in the Dump Recording Wizard.
-------------
PR Review Comment: https://git.openjdk.org/jmc/pull/652#discussion_r2193480170
More information about the jmc-dev
mailing list