RFR: 8371: Stacktrace should hide hidden frames
Erik Gahlin
egahlin at openjdk.org
Tue Mar 25 20:37:27 UTC 2025
On Tue, 25 Mar 2025 19:27:30 GMT, Suchita Chaturvedi <schaturvedi at openjdk.org> wrote:
> JFR tool is hiding all the hidden frames. But in JMC, Stacktrace view is still showing lot of hidden methods which is not required from the users point of view. Hence, we will be hiding all the hidden frames as part of this enhancement.
>
> Also, we have updated some test cases also in order to get rid of hidden frames which were expected by the test cases.
- Shouldn't this be something you enable/disable in a preferences dialog?
- Allocating an ArrayList every time a frame is requested seems unnecessary.
- What about the time complexity of iterating through a stack trace? Isn't this now O(n^2) instead of O(n)?
-------------
PR Comment: https://git.openjdk.org/jmc/pull/632#issuecomment-2752451834
More information about the jmc-dev
mailing list