RFR: 8365: Jolokia - Additional support for security mechanisms related to SSL / authentication, discovery restrictions [v3]

[Alex Macdonald]

On Tue, 29 Jul 2025 11:21:02 GMT, Martin Skarsaune <duke at openjdk.org> wrote:

>> Note: The majority of the work in this PR is to make it work well with RMI connections. For Jolokia however, it should work out of the box as setting the env var will force https.
>
> Martin Skarsaune has updated the pull request incrementally with one additional commit since the last revision:
> 
>   JMC-8365: Make secure button updating null safe

Overall looks good to me, commented with a couple of minor things

application/org.openjdk.jmc.browser/src/main/java/org/openjdk/jmc/browser/wizards/ConnectionWizardPage.java line 441:

> 439: 			customUrlButton.setVisible(false);
> 440: 		}
> 441: 

Extra empty line

application/org.openjdk.jmc.browser/src/main/java/org/openjdk/jmc/browser/wizards/ConnectionWizardPage.java line 706:

> 704: 	}
> 705: 
> 706: 	private boolean requireSecureConnection() {

Small nit, but maybe this could be something like `isSecureConnectionRequired` ? Just thinking for initial readability where there's `requireSecureConnection(requireSecureConnection())` at line 682.

-------------

PR Review: https://git.openjdk.org/jmc/pull/665#pullrequestreview-3315623029
PR Review Comment: https://git.openjdk.org/jmc/pull/665#discussion_r2414407062
PR Review Comment: https://git.openjdk.org/jmc/pull/665#discussion_r2414413035