RFR: 5561: Support for Crypto Events in JMC [v4]

Marcus Hirt hirt at openjdk.org
Mon Feb 2 15:16:34 UTC 2026


On Tue, 23 Dec 2025 22:45:13 GMT, Suchita Chaturvedi <schaturvedi at openjdk.org> wrote:

>> This PR enhances the JMC UI for adding new information related to crypto events: specifically X509CertificateEvent.
>> 
>> This PR adds a new rule with respect to X509CertificateEvent which provides alert related to expired/expiring certificates and weak signature algorithms or weak key length or key type. The rule gives a basic overview of all the certificate ids which needs action or attention, however complete details are provided as part of a new screen - Security.
>> 
>> Attaching the screenshots here for better reference:
>> 
>> Rule Page:
>> 
>> <img width="362" height="373" alt="image" src="https://github.com/user-attachments/assets/4707e6b2-76be-4b1e-9f32-c6139851d86c" />
>> 
>> Security Screen Page:
>> 
>> <img width="959" height="385" alt="image" src="https://github.com/user-attachments/assets/5026e2b7-2754-47bc-a42d-5672f9f087d7" />
>
> Suchita Chaturvedi has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fixing spotless failure

application/org.openjdk.jmc.ui/src/main/java/org/openjdk/jmc/ui/UIPlugin.java line 195:

> 193: 	public static final String ICON_FIND = "search-glass.png"; //$NON-NLS-1$
> 194: 
> 195: 	public static final String ICON_CRYPTO_ACTION = "crypto_action.svg"; //$NON-NLS-1$

These keep being created over and over. Should they be registered (UIPlugin.registerImage(...)) so that we don't leak images?
E.g. 

registerImage(registry, ICON_CRYPTO_ACTION, ICON_CRYPTO_ACTION);                                                                                                       
etc.

-------------

PR Review Comment: https://git.openjdk.org/jmc/pull/686#discussion_r2754838657


More information about the jmc-dev mailing list