RFR: 5561: Support for Crypto Events in JMC [v4]
Marcus Hirt
hirt at openjdk.org
Mon Feb 2 15:16:34 UTC 2026
On Mon, 2 Feb 2026 15:11:25 GMT, Marcus Hirt <hirt at openjdk.org> wrote:
>> Suchita Chaturvedi has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Fixing spotless failure
>
> application/org.openjdk.jmc.ui/src/main/java/org/openjdk/jmc/ui/UIPlugin.java line 195:
>
>> 193: public static final String ICON_FIND = "search-glass.png"; //$NON-NLS-1$
>> 194:
>> 195: public static final String ICON_CRYPTO_ACTION = "crypto_action.svg"; //$NON-NLS-1$
>
> These keep being created over and over. Should they be registered (UIPlugin.registerImage(...)) so that we don't leak images?
> E.g.
>
> registerImage(registry, ICON_CRYPTO_ACTION, ICON_CRYPTO_ACTION);
> etc.
Then, instead of getting the descriptors and creating the images in the label provider, just do UIPlugin.getDefault().getImage(UIPlugin.ICON_CRYPTO_ACTION) and so on.
-------------
PR Review Comment: https://git.openjdk.org/jmc/pull/686#discussion_r2754850928
More information about the jmc-dev
mailing list