RFR: 6832: Should allow plotting line charts for all quantities [v2]

Marcus Hirt hirt at openjdk.org
Mon Feb 2 15:25:58 UTC 2026


On Mon, 19 Jan 2026 18:34:21 GMT, Aymane Harmaz <aharmaz at openjdk.org> wrote:

>> This PR makes sure line charts cover all the events across multiple IItemIterables, and makes it possible for linear quantities to be represented as line charts on custom pages.
>
> Aymane Harmaz has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains three commits:
> 
>  - update copyright year in AttributeComponentConfiguration
>  - implemented merge sorting of items from multiple chunks
>  - 6832: Should allow plotting line charts for all quantities

Changes requested by hirt (Lead).

core/org.openjdk.jmc.common/src/main/java/org/openjdk/jmc/common/collection/PeekingIterator.java line 55:

> 53: 		if (!this.hasPeeked) {
> 54: 			this.hasPeeked = true;
> 55: 			this.peekedElement = this.sourceIterator.next();

Should there be a hasNext() check here?

-------------

PR Review: https://git.openjdk.org/jmc/pull/688#pullrequestreview-3740147357
PR Review Comment: https://git.openjdk.org/jmc/pull/688#discussion_r2754889844


More information about the jmc-dev mailing list